Skip to content

ci: bump setup-soldr v0.9.24 → v0.9.35 (~7s warm-run win)#333

Merged
zackees merged 1 commit into
mainfrom
chore/setup-soldr-0.9.35
May 31, 2026
Merged

ci: bump setup-soldr v0.9.24 → v0.9.35 (~7s warm-run win)#333
zackees merged 1 commit into
mainfrom
chore/setup-soldr-0.9.35

Conversation

@zackees

@zackees zackees commented May 31, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Bumps zackees/setup-soldr from v0.9.24 to v0.9.35 across all .github/workflows/ pins.

What's in v0.9.35 (vs v0.9.24)

#304/#308 — FS-first rustup probe (the big win)

Eliminates the ~7s rustup toolchain list subprocess that fired on every warm CI run by reading $RUSTUP_HOME/toolchains/ directly. Validated on zccache CI: linux/Test wall clock dropped 30.0s → 14.8s (-15.2s).

#302/#303 — Sub-phase timing observability

Each setup phase now prints a {sub=Xs sub=Ys} breakdown inline, so the slow spots in resolve/toolchain phases are visible without enabling debug mode.

Scope

Mechanical bump only — replaces zackees/setup-soldr@v0.9.24 → zackees/setup-soldr@v0.9.35 in 11 workflow files. No other changes.

Test plan

  • CI green on this PR (every workflow exercises the new action version)
  • Confirm warm-run wall clock improvement matches the expected ~7-15s shave in workflow logs

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated CI/CD infrastructure with newer versions of development build tools across all continuous integration workflows to improve build reliability, enhance testing consistency, and support better development environment stability.

@zackees @claude
ci: bump setup-soldr v0.9.24 → v0.9.35
dcb831e 
Picks up the cumulative perf + observability wins:

- #302/#303: sub-phase timing observability (each setup phase now
  prints a `{sub=Xs sub=Ys}` breakdown inline, surfacing the slow
  spots).
- #304/#308: FS-first rustup probe — eliminates ~7s `rustup
  toolchain list` subprocess on every warm CI run by reading
  $RUSTUP_HOME/toolchains/ directly. Validated on zccache CI:
  linux/Test wall clock dropped 30.0s → 14.8s (-15.2s).

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
@zackees zackees merged commit 3884f55 into main May 31, 2026
89 of 91 checks passed
@coderabbitai

coderabbitai Bot commented May 31, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 05a528ee-50a9-4a50-8db6-44301b2d1ad9

📥 Commits

Reviewing files that changed from the base of the PR and between bfba8d9 and dcb831e.

📒 Files selected for processing (11)
  • .github/workflows/acceptance-205.yml
  • .github/workflows/bench-205.yml
  • .github/workflows/check-macos.yml
  • .github/workflows/check-ubuntu.yml
  • .github/workflows/check-windows.yml
  • .github/workflows/docs.yml
  • .github/workflows/dylint.yml
  • .github/workflows/fmt.yml
  • .github/workflows/msrv.yml
  • .github/workflows/template_build.yml
  • .github/workflows/template_native_build.yml
📝 Walkthrough

Walkthrough

All CI and build workflows are updated to use zackees/setup-soldr version v0.9.35 instead of v0.9.24. The version bump is applied consistently across 11 workflow files with no changes to workflow logic, triggers, step inputs, or command execution.

Changes

Soldr setup action version bump across CI workflows

Layer / File(s) Summary
Soldr action version update
.github/workflows/acceptance-205.yml, .github/workflows/bench-205.yml, .github/workflows/check-macos.yml, .github/workflows/check-ubuntu.yml, .github/workflows/check-windows.yml, .github/workflows/docs.yml, .github/workflows/dylint.yml, .github/workflows/fmt.yml, .github/workflows/msrv.yml, .github/workflows/template_build.yml, .github/workflows/template_native_build.yml		 The zackees/setup-soldr GitHub Actions dependency is bumped uniformly from v0.9.24 to v0.9.35 across all CI and build workflows, including acceptance testing, benchmarking, platform-specific checks (macOS, Ubuntu, Windows), documentation, linting, formatting, MSRV validation, and template builds.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • FastLED/fbuild#253: Both PRs modify the same GitHub Actions "Setup soldr" steps in workflow files by changing zackees/setup-soldr configuration.

  • FastLED/fbuild#185: Both PRs touch .github/workflows/msrv.yml's zackees/setup-soldr setup step with updates to the soldr or toolchain configuration.

Poem

🐰 A rabbit hops through workflows with glee,
Version bumps from v0.24 to v.35!
Soldr tools now set up with newer care,
Each CI job refreshed, tested everywhere,
Consistency across the build affair—thump thump! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/setup-soldr-0.9.35

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

This was referenced May 31, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@zackees